[RF-DOCS] Update Rails Testing Guide [ci skip]#2
Conversation
bhumi1102
left a comment
There was a problem hiding this comment.
Reviewed up to line 500
bhumi1102
left a comment
There was a problem hiding this comment.
Reviewed up to line 1000 😊
bhumi1102
left a comment
There was a problem hiding this comment.
Finished my review. This was a long one, thanks @OughtPuts for working through it!
Ridhwana
left a comment
There was a problem hiding this comment.
This was a really long guide, and you've made some excellent updates, @OughtPuts! 💛 Thank you! ✨
I left some feedback—feel free to incorporate what you find valuable. One thing I did notice is the shift between using "we/our" and "you" throughout the guide, which felt a bit inconsistent. It seems to have carried over from the initial version.
While it's perfectly fine to use those pronouns when necessary, I find that the tone of the most of the guides (at least the newer ones) tends to lean more toward neutral language or the use of "you." I believe @bhumi1102 follows a similar approach (based on reviewing her work), but I stand to be corrected. Either way, it's a discussion worth having if we need to 😊 .
…m:OughtPuts/rails into harriet-guides-testing-rails-applications
e5c25db to
0adae5f
Compare
Co-authored-by: Petrik de Heus <petrik@deheus.net>
0adae5f to
99fa37d
Compare
Motivation / Background
This Pull Request has been created to update the testing guide.
Detail
assert_routingwas added to the rails assertions.Additional information
For discussion:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]